From 5dd98385e03b9cc7c912b1b50f7c406df117a9af Mon Sep 17 00:00:00 2001 From: Ekaitz Zarraga Date: Tue, 12 Aug 2025 00:35:18 +0200 Subject: piece-table: Don't allocate in piece_table_to_string `piece_table_to_string` now receives a buffer and we also provide a function that returns the length of the piece table. TODO: the `piece_table_to_string` adds null termination, that makes the buffer needed `piece_table_length(pt) + 1`. This we should document or do more obvious. --- src/piece-table.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) (limited to 'src/piece-table.c') diff --git a/src/piece-table.c b/src/piece-table.c index a8ddd1e..b29f3be 100644 --- a/src/piece-table.c +++ b/src/piece-table.c @@ -415,15 +415,19 @@ piece_table_index (piece_table *pt, size_t pos) pt->cached->start + pos - pt->cached_offset); } -char * -piece_table_to_string (piece_table *pt) +void +piece_table_to_string (piece_table *pt, char *buf) { size_t i; - char *ret = malloc (sizeof (*ret) * pt->length + 1); for (i = 0; i < pt->length; i++) { - ret[i] = piece_table_index(pt, i); + buf[i] = piece_table_index (pt, i); } - ret[i] = '\0'; - return ret; + buf[i] = '\0'; +} + +size_t +piece_table_length (piece_table *pt) +{ + return pt->length; } -- cgit v1.2.3